[coreclr] Block test that should not be run

[ilonatommy]

Fixes #97241.
This test was not supposed to be run on coreclr.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #97241.
This test was not supposed to be run on coreclr.

Author:	ilonatommy
Assignees:	ilonatommy
Labels:	area-System.Globalization, blocking-clean-ci
Milestone:	-

[stephentoub]

This test was not supposed to be run on coreclr.

Why does "IsIcuGlobalization" rule out coreclr?

[ilonatommy]

This test was not supposed to be run on coreclr.

Why does "IsIcuGlobalization" rule out coreclr?

runtime/src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs

Line 392 in 23eaf25

public static bool IsIcuGlobalization => !IsInvariantGlobalization && (IsHybridGlobalizationOnApplePlatform || ICUVersion > new Version(0, 0, 0, 0));

It seems that coreclr does not load ICU, other tests marked by this property were skipped. This very tests assumes that the platform uses ICU4C hashing algorithm and depends on how ICU behaves (ignores specific characters in hashing). I am not sure what coreclr uses instead of ICU, probably NLS.

[stephentoub]

It seems that coreclr does not load ICU

It does. We use ICU by default on coreclr; you have to opt-out of it to use NLS instead. And I just tried and IsIcuGlobalization does behave as I'd expect and return true when running with coreclr.

If the goal of using IsIcuGlobalization was to avoid running on coreclr, I don't believe this is doing that.

[tarekgh]

At some point @jkotas fixed a bug in tests which used to check ICU version before loading it. #96288.

[jkotas]

The test was failing on Win7 and early Win10 that does not have ICU. This change will correctly disable the test on these Windows version.

The test change is correct, just the commit description is not quite right.

[stephentoub]

The test change is correct, just the commit description is not quite right.

👍