Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Arm64 encodings for IF_SVE_CX_4A group #95918

Merged
merged 4 commits into from
Dec 18, 2023
Merged

Add Arm64 encodings for IF_SVE_CX_4A group #95918

merged 4 commits into from
Dec 18, 2023

Conversation

SwapnilGaikwad
Copy link
Contributor

This group emits various compare instructions.

This clr output matches the one from capstone.

...
cmpeq p15.b, p0/z, z0.b, z10.b 
cmpge p14.h, p1/z, z10.h, z23.h 
cmpgt p13.s, p2/z, z20.s, z24.s 
cmphi p12.d, p3/z, z30.d, z25.d 
cmphs p11.b, p4/z, z1.b, z26.b 
cmpge p10.h, p5/z, z27.h, z11.h 
cmphi p11.s, p6/z, z28.s, z12.s 
cmphs p0.d, p7/z, z29.d, z13.d 
cmpgt p2.b, p0/z, z30.b, z14.b 
cmpne p3.h, p1/z, z15.h, z20.h 
...

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 12, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 12, 2023
@ghost
Copy link

ghost commented Dec 12, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This group emits various compare instructions.

This clr output matches the one from capstone.

...
cmpeq p15.b, p0/z, z0.b, z10.b 
cmpge p14.h, p1/z, z10.h, z23.h 
cmpgt p13.s, p2/z, z20.s, z24.s 
cmphi p12.d, p3/z, z30.d, z25.d 
cmphs p11.b, p4/z, z1.b, z26.b 
cmpge p10.h, p5/z, z27.h, z11.h 
cmphi p11.s, p6/z, z28.s, z12.s 
cmphs p0.d, p7/z, z29.d, z13.d 
cmpgt p2.b, p0/z, z30.b, z14.b 
cmpne p3.h, p1/z, z15.h, z20.h 
...
Author: SwapnilGaikwad
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution
Milestone: -

@SwapnilGaikwad
Copy link
Contributor Author

@a74nh , @kunalspathak , @BruceForstall

kunalspathak
kunalspathak reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @SwapnilGaikwad . Added some comments.

src/coreclr/jit/codegenarm64.cpp Outdated Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
src/coreclr/jit/emitarm64.cpp Show resolved Hide resolved
src/coreclr/jit/emitarm64.h Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Dec 12, 2023
Closed
@a74nh a74nh mentioned this pull request Dec 14, 2023
Merged
@kunalspathak kunalspathak added the arm-sve Work related to arm64 SVE/SVE2 support label Dec 14, 2023
@build-analysis build-analysis bot mentioned this pull request Dec 15, 2023
Closed
@a74nh a74nh mentioned this pull request Dec 18, 2023
Merged
kunalspathak
kunalspathak approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kunalspathak kunalspathak merged commit 9378b06 into dotnet:main Dec 18, 2023
126 of 129 checks passed
@kunalspathak kunalspathak mentioned this pull request Dec 18, 2023
Closed
@SwapnilGaikwad SwapnilGaikwad deleted the github-sve-cx_4a branch December 20, 2023 10:49
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a74nh a74nh a74nh left review comments

@BruceForstall BruceForstall BruceForstall left review comments

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwapnilGaikwad @a74nh @BruceForstall @kunalspathak