Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateTimeFormat comments for year pattern (#95629) #95650

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Fix DateTimeFormat comments for year pattern (#95629) #95650

merged 1 commit into from
Dec 6, 2023

Conversation

Guiorgy
Copy link
Contributor

@Guiorgy Guiorgy commented Dec 5, 2023

Fixes #95629

Comments describing the format for the year pattern with more than 2 'y'-s ('yyy', 'yyyy', ...) did not correctly reflect the implementation.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Dec 5, 2023
@ghost
Copy link

ghost commented Dec 5, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Comments describing the format for the year pattern with more than 4 'y'-s ('yyyyy', ...) did not correctly reflect the implementation.

Author: Guiorgy
Assignees: -
Labels:

area-System.Globalization

Milestone: -

Comments describing the format for the year pattern with more than 2 'y'-s ('yyy', 'yyyy', ...) did not correctly reflect the implementation.
@tarekgh tarekgh added this to the 9.0.0 milestone Dec 5, 2023
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Guiorgy!

@tarekgh tarekgh merged commit 6798f84 into dotnet:main Dec 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Globalization community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icorrect comment for the year pattern in DateTimeFormat
2 participants