Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Check for reachable preds in RBO #95556

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jakobbotsch
Copy link
Member

Nothing guarantees that all preds are reachable, in which case the "dominates" query does not make sense.

Fixes the issue found in https://dev.azure.com/dnceng-public/public/_build/results?buildId=487403&view=ms.vss-build-web.run-extensions-tab.

Nothing guarantees that all preds are reachable, in which case the
"dominates" query does not make sense.
@ghost ghost assigned jakobbotsch Dec 3, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Dec 3, 2023
@ghost
Copy link

ghost commented Dec 3, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Nothing guarantees that all preds are reachable, in which case the "dominates" query does not make sense.

Fixes the issue found in https://dev.azure.com/dnceng-public/public/_build/results?buildId=487403&view=ms.vss-build-web.run-extensions-tab.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr

Milestone: -

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib PTAL @AndyAyersMS

@jakobbotsch jakobbotsch merged commit 4bbf678 into dotnet:main Dec 4, 2023
129 checks passed
@jakobbotsch jakobbotsch deleted the rbo-unreachable-preds branch December 4, 2023 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants