Skip to content

Conversation

@t-mustafin
Copy link
Contributor

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-GC-coreclr labels Dec 1, 2023
@ghost
Copy link

ghost commented Dec 1, 2023

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Part of #84834

cc @janvorli @wscho77 @HJLeee @clamp03 @JongHeonChoi @gbalykov @viewizard @ashaurtaev @sirntar @yurai007 @tomeksowi @brucehoult @DenisParal

Author: t-mustafin
Assignees: -
Labels:

area-GC-coreclr, community-contribution

Milestone: -

@gbalykov
Copy link
Member

gbalykov commented Dec 1, 2023

@janvorli please take a look, after #80295 changes from #84797 were disabled, which now leads to error during coreclr initialization on risc-v board on main branch

@janvorli
Copy link
Member

janvorli commented Dec 1, 2023

@t-mustafin, @gbalykov I am sorry for breaking this for you. As for your fix, I'd prefer modifying the Unix version of GCToOSInterface::GetVirtualMemoryLimit() to return GCToOSInterface::GetVirtualMemoryMaxAddress() instead of (size_t)-1 if no rlimit is set and leaving the code in gc.cpp unchanged.

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 99877a1 into dotnet:main Dec 4, 2023
@t-mustafin t-mustafin deleted the riscv_fix_gc_valloc branch December 6, 2023 09:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-GC-coreclr community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants