-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RISC-V] Implement some of the NYI methods in unwindriscv64 #95128
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis PR contains implementation for some of the NYI methods in unwindriscv64. About About Part of #84834
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Noti: @shushanhf I checked dwarf register numbers for other archs as well as riscv. I think loongarch64 DWARF register number for floating-point register starts from runtime/src/coreclr/jit/unwindloongarch64.cpp Lines 123 to 125 in 84087b4
|
I sent an email about it to @shushanhf last week. If I remember correctly, he responded that it could have been a part of SIMD functionality that hasn't been pushed to upstream. I also made a small fix for loongarch64 (sirntar@58edd0b), but since I don't have a loongarch64 platform to test it, I didn't create any pull request. |
Ah. You already sent an email to him. I think he will handle it. :) |
Sorry, I forgot to reply to all. Thanks very much! I think that is for SIMD registers context. Although the main branch doesn't contain the LoongArch64-SIMD |
This PR contains implementation for some of the NYI methods in unwindriscv64.
About
Compiler::mapRegNumToDwarfReg
:I've mapped only basic and floating pointer registers as we are not supporting V-extension right now.
About
GetUnwindSizeFromUnwindHeader
:I'm not 100% certain whether this is a correct implementation, so I would be grateful if someone can check it.
Part of #84834
cc @wscho77 @HJLeee @clamp03 @JongHeonChoi @t-mustafin @gbalykov @ashaurtaev @yurai007 @tomeksowi @Bajtazar