-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-staging] Store entry assembly path for easy access for diagnostics #95047
[release/7.0-staging] Store entry assembly path for easy access for diagnostics #95047
Conversation
- Add `g_EntryAssemblyPath` global variable holding the full path to the entry assembly - Set right before loading the entry assembly (so also before startup hooks are run) - NULL if there is no entry assembly - Ensure value is included dumps - For triage dumps, the dumped value is updated to only be the assembly file name instead of the full path
/backport to release/6.0-staging |
Started backporting to release/6.0-staging: https://github.com/dotnet/runtime/actions/runs/6938665661 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will take for consideration in 7.0.x
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #95045 to release/7.0-staging /cc @elinor-fung Customer ImpactThe entry assembly is currently not exposed in a way that is easy to access for diagnostics - for example, crash dumps. This means that for an application started via the dotnet executable ( See #94474 TestingManual validation. RiskLow IMPORTANT: If this backport is for a servicing release, please verify that:
|
Backport of #95045 to release/7.0-staging
/cc @elinor-fung
Customer Impact
The entry assembly is currently not exposed in a way that is easy to access for diagnostics - for example, crash dumps. This means that for an application started via the dotnet executable (
dotnet app.dll
), there isn't a good way to determine the managed assembly from a dump - particularly so for a non-heap dump.See #94474
Testing
Manual validation.
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging
, notrelease/X.0
.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.