Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Added DOTNET_JitRawHexCode/JitRawHexCodeFile #94896

Merged
merged 3 commits into from
Nov 18, 2023
Merged

JIT: Added DOTNET_JitRawHexCode/JitRawHexCodeFile #94896

merged 3 commits into from
Nov 18, 2023

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Nov 17, 2023 •
edited
Loading

This adds a new environment variable, DOTNET_JitRawHexCode/JitRawHexCodeFile, in Debug/Checked builds that will enable writing the native code in hex to given file or stdout.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 17, 2023
@ghost ghost assigned TIHan Nov 17, 2023
@ghost
Copy link

ghost commented Nov 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This adds a new environment variable, DOTNET_JitDisasmHexDumpFile, in Debug/Checked builds that will enable writing the native code in hex to a file for the given DOTNET_JitDisasm.

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr
Milestone: -

@TIHan
Copy link
Contributor Author

TIHan commented Nov 17, 2023

@dotnet/jit-contrib @kunalspathak

kunalspathak
kunalspathak reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would go something without "disasm" (because it does not have mnemonics) and add "raw" in it . Something like JitRawHexCodeFile or similar.

src/coreclr/jit/codegencommon.cpp Outdated Show resolved Hide resolved
@build-analysis build-analysis bot mentioned this pull request Nov 17, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Nov 17, 2023
Closed
@TIHan TIHan changed the title JIT: Added DOTNET_JitDisasmHexDumpFile JIT: Added DOTNET_RawHexCode/RawHexCodeFile Nov 17, 2023
@TIHan TIHan changed the title JIT: Added DOTNET_RawHexCode/RawHexCodeFile JIT: Added DOTNET_JitRawHexCode/JitRawHexCodeFile Nov 17, 2023
@TIHan
Copy link
Contributor Author

TIHan commented Nov 17, 2023

@dotnet/jit-contrib this is ready again.

kunalspathak
kunalspathak approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/coreclr/jit/utils.cpp Show resolved Hide resolved
@TIHan TIHan merged commit 9bc37cb into dotnet:main Nov 18, 2023
127 of 129 checks passed
@TIHan TIHan deleted the hex-dump branch November 18, 2023 04:05
@a74nh a74nh mentioned this pull request Nov 24, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments

@BruceForstall BruceForstall BruceForstall left review comments

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@TIHan TIHan

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TIHan @jakobbotsch @BruceForstall @kunalspathak