Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type.GetMethod(name, genericParameterCount, bindingAttr, types) overload #94889

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Type.GetMethod(name, genericParameterCount, bindingAttr, types) overload #94889

merged 1 commit into from
Nov 21, 2023

Conversation

I-SER-I
Copy link
Contributor

@I-SER-I I-SER-I commented Nov 17, 2023

close #90995

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 17, 2023
@ghost
Copy link

ghost commented Nov 17, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

close #90995

Author: I-SER-I
Assignees: -
Labels:

area-System.Reflection, new-api-needs-documentation
Milestone: -

This was referenced Nov 17, 2023
Closed
Closed
@I-SER-I I-SER-I marked this pull request as ready for review November 17, 2023 14:59
@build-analysis build-analysis bot mentioned this pull request Nov 17, 2023
Closed
@MichalStrehovsky MichalStrehovsky mentioned this pull request Nov 20, 2023
Open
buyaa-n
buyaa-n approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@buyaa-n buyaa-n left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thank you @I-SER-I !

Failures unrelated and known

@buyaa-n buyaa-n merged commit 52b4c82 into dotnet:main Nov 21, 2023
172 of 176 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@buyaa-n buyaa-n buyaa-n approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees
No one assigned
Labels
area-System.Reflection community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
2 participants
@I-SER-I @buyaa-n