-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882
[release/8.0-staging] Fix JsonArray.Add and ReplaceWith regressions. #94882
Conversation
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #94854 to release/8.0-staging /cc @eiriktsarpalis Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
@eiriktsarpalis please ensure the package authoring is done. |
Approved over email. |
I'm looking at the CI failures. |
…rsion prop: Assembly 'System.Text.Json.TestLibrary.Roslyn3.11' with identity 'System.Text.Json.TestLibrary.Roslyn3.11, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' uses 'System.Text.Json, Version=8.0.0.1, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' which has a higher version than referenced assembly 'System.Text.Json' with identity 'System.Text.Json, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
@ViktorHofer I think I found the root cause. Can you please review my commit? Code Complete for the Jan Release is tomorrow Wednesday so we need to get this merged ASAP. |
The old error went away, but a new one showed up. |
...son/tests/System.Text.Json.SourceGeneration.TestLibrary/System.Text.Json.TestLibrary.targets
Outdated
Show resolved
Hide resolved
…neration.TestLibrary/System.Text.Json.TestLibrary.targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The packaging error is fixed. The new CI failures are pre-existing and unrelated. This is good to merge. Thanks @ViktorHofer.
Backport of #94854 to release/8.0-staging
/cc @eiriktsarpalis
Customer Impact
Fixes a customer-reported regression from .NET 7 when trying to add a
JsonElement
value to aJsonArray
. See #94842 for more details.Testing
Added relevant regression testing.
Risk
Low. Makes a relatively straightforward change to product code.