Fix removal of unreachable BBJ_CALLFINALLY/BBJ_ALWAYS on Linux/arm #94751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the test case, with extreme amounts of unreachable code, we could remove a BBJ_CALLFINALLY that was not marked as `BBF_DONT_REMOVE`. If so, it would not go down the code path that handles removing the BBJ_ALWAYS pair of the BBJ_CALLFINALLY, which handles removing the `BBF_FINALLY_TARGET` flag on Linux/arm. Refactor the code so unreachable BBJ_CALLFINALLY/BBJ_ALWAYS pairs are always handled. Fixes dotnet#94680
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsIn the test case, with extreme amounts of unreachable code, we could remove a BBJ_CALLFINALLY that was not marked as Refactor the code so unreachable BBJ_CALLFINALLY/BBJ_ALWAYS pairs are always handled. Fixes #94680
|
jakobbotsch
approved these changes
Nov 15, 2023
|
cc @dotnet/jit-contrib |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test case, with extreme amounts of unreachable code, we could remove a BBJ_CALLFINALLY that was not marked as
BBF_DONT_REMOVE. If so, it would not go down the code path that handles removing the BBJ_ALWAYS pair of the BBJ_CALLFINALLY, which handles removing theBBF_FINALLY_TARGETflag on Linux/arm.Refactor the code so unreachable BBJ_CALLFINALLY/BBJ_ALWAYS pairs are always handled.
Fixes #94680