Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 14, 2023

Backport of #94602 to release/7.0-staging

/cc @ivanpovazan

Customer Impact

ASP.NET test suite uses GetCustomAttributes API with a custom attribute provider: https://github.com/dotnet/aspnetcore/blob/402e7fc10aa304775f50d318c8a4dafbf46dbfe0/src/Shared/PropertyAsParameterInfo.cs#L15 which was not properly supported by Mono causing about 100 failing tests, as reported here: #94437 (comment)

This PR fixes the issue.

Testing

This PR includes a unit test which verifies the fix that should pass on CI.

Risk

Low.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Nov 14, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #94602 to release/7.0-staging

/cc @ivanpovazan

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Reflection

Milestone: -

@ivanpovazan
Copy link
Member

The added test has successfully passed on CI.
The other CI failures are unrelated.

This is safe to be merged.

@carlossanlop
Copy link
Contributor

@ivanpovazan @lambdageek did this get Tactics approval? Today's code complete.

@carlossanlop
Copy link
Contributor

I'm flowing staging to internal now, so the branches are closed. This will have to wait until the January release.

@steveisok steveisok added Servicing-rejected and removed Servicing-consider Issue for next servicing release review labels Nov 21, 2023
@steveisok
Copy link
Member

Per tactics, this change unfortunately doesn't meet the bar in terms of customer impact. @ivanpovazan if you find this blocks customers in a significant way, please identify and reopen.

@steveisok steveisok closed this Nov 21, 2023
@jkotas jkotas deleted the backport/pr-94602-to-release/7.0-staging branch November 27, 2023 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-VM-reflection-mono Reflection issues specific to MonoVM Servicing-rejected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants