Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: consistently handle no return calls in qmarks #94690

Merged
merged 1 commit into from
Nov 14, 2023
Merged

JIT: consistently handle no return calls in qmarks #94690

merged 1 commit into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. JIT: consistently handle no return calls in qmarks 

    When we expand QMARKS, ensure that any block with a no-return call gets
changed to BBJ_THROW.

This fixes a case I am seeing with cross-block local assertion prop,
as the upper QMARK gets optimized away and so we don't check if the
expansing has any noreturn calls.

It also happens in places with just within-block local assertion prop.

Contributes to dotnet#94363.
    @AndyAyersMS
    AndyAyersMS committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a5d6a3f View commit details
    Browse the repository at this point in the history