-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ubuntu 18.04 from libraries Helix queues #94293
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsMain goal was to remove I've also risked updating from I only limited the change to Libraries legs. cc @wfurt
|
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-94293-merge-a366bc12dedb4b4bb6/System.Net.Quic.Functional.Tests/1/console.5b994ab1.log?helixlogtype=result https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-94293-merge-325f6cbe283a42cebb/System.Net.Quic.Functional.Tests/1/console.4bd19c21.log?helixlogtype=result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @dougbu who has been overseeing these kinds of changes in the last weeks. |
I don't know the context for this removal, I want to check this isn't contrary my assumption that .NET 9 will be built on Ubuntu 18.04 (per #91826 (comment))? |
18.04 is EOL https://ubuntu.com/blog/ubuntu-18-04-eol-for-devices so I'm not sure what we really want with that. @jkotas or @richlander may have some more insight. In this particular case this PR only changes the underlying queue while tests still running in the container e.g. Debian or Alpine. |
There is a difference between what we support and test and what we build against. For example, .NET 8 is built against Ubuntu 16.04 but it is supported (by Microsoft) on Ubuntu 20.04+ only. |
Main goal was to remove
prereqs:ubuntu-18.04-helix-arm64v8
, and there was evenprereqs:ubuntu-22.04-helix-arm64v8
already in place just above, so I just left one line instead of two.I've also risked updating from
Ubuntu.1804.ArmArch.Open
helix machine toUbuntu.2004.Armarch.Open
because I see this issue closed dotnet/arcade#10932. If it won't fly, I'll roll it back.I only limited the change to Libraries legs.
cc @wfurt