Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ubuntu 18.04 from libraries Helix queues #94293

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

CarnaViire
Copy link
Member

Main goal was to remove prereqs:ubuntu-18.04-helix-arm64v8, and there was even prereqs:ubuntu-22.04-helix-arm64v8 already in place just above, so I just left one line instead of two.

I've also risked updating from Ubuntu.1804.ArmArch.Open helix machine to Ubuntu.2004.Armarch.Open because I see this issue closed dotnet/arcade#10932. If it won't fly, I'll roll it back.

I only limited the change to Libraries legs.

cc @wfurt

@ghost
Copy link

ghost commented Nov 2, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Main goal was to remove prereqs:ubuntu-18.04-helix-arm64v8, and there was even prereqs:ubuntu-22.04-helix-arm64v8 already in place just above, so I just left one line instead of two.

I've also risked updating from Ubuntu.1804.ArmArch.Open helix machine to Ubuntu.2004.Armarch.Open because I see this issue closed dotnet/arcade#10932. If it won't fly, I'll roll it back.

I only limited the change to Libraries legs.

cc @wfurt

Author: CarnaViire
Assignees: CarnaViire
Labels:

area-Infrastructure-libraries

Milestone: -

@CarnaViire
Copy link
Member Author

CarnaViire commented Nov 2, 2023

Ubuntu.2004.Armarch.Open queue and prereqs:ubuntu-22.04-helix-arm64v8 image seem to be working fine, e.g.

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-94293-merge-a366bc12dedb4b4bb6/System.Net.Quic.Functional.Tests/1/console.5b994ab1.log?helixlogtype=result
Console log: 'System.Net.Quic.Functional.Tests' from job a366bc12-dedb-4b4b-b680-611df092739e (ubuntu.2004.armarch.open) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-22.04-helix-arm64v8 on a00068L

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-94293-merge-325f6cbe283a42cebb/System.Net.Quic.Functional.Tests/1/console.4bd19c21.log?helixlogtype=result
Console log: 'System.Net.Quic.Functional.Tests' from job 325f6cbe-283a-42ce-bb7a-d69420eedac6 (ubuntu.2004.armarch.open) using docker image mcr.microsoft.com/dotnet-buildtools/prereqs:debian-11-helix-arm64v8 on a00068M

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop
Copy link
Member

cc @dougbu who has been overseeing these kinds of changes in the last weeks.

@tmds
Copy link
Member

tmds commented Nov 2, 2023

I don't know the context for this removal, I want to check this isn't contrary my assumption that .NET 9 will be built on Ubuntu 18.04 (per #91826 (comment))?

@wfurt
Copy link
Member

wfurt commented Nov 2, 2023

18.04 is EOL https://ubuntu.com/blog/ubuntu-18-04-eol-for-devices so I'm not sure what we really want with that. @jkotas or @richlander may have some more insight.

In this particular case this PR only changes the underlying queue while tests still running in the container e.g. Debian or Alpine.

@jkotas
Copy link
Member

jkotas commented Nov 2, 2023

I don't know the context for this removal, I want to check this isn't contrary my assumption that .NET 9 will be built on Ubuntu 18.04

There is a difference between what we support and test and what we build against. For example, .NET 8 is built against Ubuntu 16.04 but it is supported (by Microsoft) on Ubuntu 20.04+ only.

@jkotas jkotas merged commit 2c1e3b3 into dotnet:main Nov 2, 2023
101 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need ubuntu 20.04 and/or 22.04 ARM Helix queues
6 participants