Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MT][browser] Disabling tests failing in the last two weeks on MT. #94051

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Oct 26, 2023

Continuation of #93224.

Why do we remove test disabling and increase the thread for it instead:
Failure of type: #91549 is caused by too small thread pool size in the browser, so we could avoid it by increasing it.

 System.Threading.Tasks.TaskSchedulerException : An exception was thrown by a TaskScheduler.
info: ---- System.Threading.ThreadStartException : Thread failed to start.
info: -------- System.ExecutionEngineException : mono_thread_platform_create_thread() failed
info:    at System.Threading.Tasks.Task.ScheduleAndStart(Boolean needsProtection)
info:    at System.Threading.Tasks.Task.Start(TaskScheduler scheduler)
info:    at System.Threading.Tasks.Task.Start()
info:    at System.Threading.Tasks.Tests.TaskPropertiesTests.TaskOptionTest(Boolean runSync)
info:    at System.Threading.Tasks.Tests.TaskPropertiesTests.TaskOptionsTestAsync()
info:    at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
info:    at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
info: ----- Inner Stack Trace -----
info:    at System.Threading.Thread.ThrowThreadStartException(Exception ex)
info:    at System.Threading.Thread.StartCore()
info:    at System.Threading.Thread.Start(Object parameter, Boolean captureContext, Boolean internalThread)
info:    at System.Threading.Thread.UnsafeStart(Object parameter)
info:    at System.Threading.Tasks.ThreadPoolTaskScheduler.QueueTask(Task task)
info:    at System.Threading.Tasks.TaskScheduler.InternalQueueTask(Task task)
info:    at System.Threading.Tasks.Task.ScheduleAndStart(Boolean needsProtection)
info: ----- Inner Stack Trace -----

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture disabled-test The test is disabled in source code against the issue area-VM-threading-mono labels Oct 26, 2023
@ghost
Copy link

ghost commented Oct 26, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Continuation of #93224.

Author: ilonatommy
Assignees: -
Labels:

arch-wasm, disabled-test, area-VM-threading-mono

Milestone: -

@ghost ghost assigned ilonatommy Oct 26, 2023
@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Oct 30, 2023

cc @pavelsavara for review of the property value change.

@ilonatommy ilonatommy merged commit 5df92ec into dotnet:main Oct 31, 2023
129 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-VM-threading-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants