-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MT][browser] Disabling tests failing in the last two weeks on MT. #94051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
arch-wasm
WebAssembly architecture
disabled-test
The test is disabled in source code against the issue
area-VM-threading-mono
labels
Oct 26, 2023
ghost
assigned ilonatommy
Oct 26, 2023
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
16 was too low, still failing
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
32 was failing
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
radical
reviewed
Oct 27, 2023
src/libraries/System.Threading.ThreadPool/tests/System.Threading.ThreadPool.Tests.csproj
Show resolved
Hide resolved
cc @pavelsavara for review of the property value change. |
pavelsavara
approved these changes
Oct 31, 2023
ghost
locked as resolved and limited conversation to collaborators
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
arch-wasm
WebAssembly architecture
area-VM-threading-mono
disabled-test
The test is disabled in source code against the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #93224.
Why do we remove test disabling and increase the thread for it instead:
Failure of type: #91549 is caused by too small thread pool size in the browser, so we could avoid it by increasing it.