Add windows support for build.sh #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume we only need this in the root script and not in the helper ones? Ie |
ViktorHofer
approved these changes
Nov 18, 2019
|
This will never be exercised in CI so please make sure it works correctly. Also expect this to be broken if someones changes the scripts as some point. |
This has been soaked in corefx for a few months, so I'm expecting it to work without issue. |
Good question. I think it's generally overkill to do it everywhere. It's best to just keep it in common entrypoints, given that our bash infra won't support windows in the foreseeable future. |
ViktorHofer
added
NO-MERGE
|
Merging as we passed the stage where build.cmd/sh is called. |
eiriktsarpalis
added a commit
that referenced
this pull request
Apr 6, 2020
This reverts commit 7783fd5.
MichalStrehovsky
pushed a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Oct 12, 2020
Merge from dotnet/runtime
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the change from dotnet/corefx#41947