Move JIT's clang-tidy flags into configuration files and add a root clang-tidy config that disables all checks. #93951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lang-tidy config that disables all checks.
jkoritzinsky
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThis helps us track our formatting rules next to the code.
|
This was referenced Oct 25, 2023
BruceForstall
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
LGTM.
Do you have a corresponding change to https://github.com/dotnet/jitutils/blob/main/src/jit-format/jit-format.cs (to remove the JIT checks)?
|
I don't have one yet. I'll take a look. |
liveans
pushed a commit
to liveans/dotnet-runtime
that referenced
this pull request
Nov 9, 2023
…lang-tidy config that disables all checks. (dotnet#93951)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us track our formatting rules next to the code.