Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IGNORE][wasm] testing perf pipeline #92964

Closed
wants to merge 1 commit into from

Conversation

radical
Copy link
Member

@radical radical commented Oct 3, 2023

No description provided.

@radical radical added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it arch-wasm WebAssembly architecture labels Oct 3, 2023
@ghost ghost assigned radical Oct 3, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 3, 2023
@ghost
Copy link

ghost commented Oct 3, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: radical
Assignees: -
Labels:

NO-MERGE, NO-REVIEW, arch-wasm

Milestone: -

@radical
Copy link
Member Author

radical commented Oct 3, 2023

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Oct 3, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical closed this Oct 3, 2023
@radical radical reopened this Oct 3, 2023
@radical
Copy link
Member Author

radical commented Oct 3, 2023

@dougbu runtime-wasm-perf was getting triggered for all PRs. Then I merged #92799 with pr: section, and trigger: none. Now, the pipeline is not getting triggered for PRs by default, like this one which has a change in one the included paths.

Do I need a trigger: also? Looking at the docs trigger seems to be for running off the repo branches like a rolling build, and pr is for running the pipeline on PRs. Any idea what I'm missing here?

Update: this is the pr:

trigger: none
pr:
branches:
include:
- main
paths:
include:
- eng/pipelines/runtime-wasm-perf.yml
- eng/pipelines/coreclr/perf*.yml
- eng/pipelines/coreclr/templates/perf-job.yml
- eng/pipelines/coreclr/templates/run-perf*
- eng/pipelines/coreclr/templates/run-scenarios-job.yml
- eng/testing/performance/*
- eng/testing/ChromeVersions.props

@dougbu
Copy link
Member

dougbu commented Oct 3, 2023

@radical @AlitzelMendez re-ticked the Require a team member's comment before building a pull request checkbox; I'm not sure why. @AlitzelMendez

that checkbox is off again

@radical radical closed this Oct 3, 2023
@radical radical reopened this Oct 3, 2023
@radical radical closed this Oct 4, 2023
@radical radical deleted the test-perf-pipeline branch October 4, 2023 00:43
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants