[release/8.0] Put HasNativeCodeReJITAware into GetFunctionAddress #92665
Conversation
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #90049 to release/8.0 /cc @mikelle-rogers Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
We need to add the changes from #90821 as well, and any other follow up work that happened if there is more. |
jeffschwMSFT
added
the
Servicing-consider
carlossanlop
added
Servicing-approved
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. @mikelle-rogers @noahfalk is this good to merge? I see some feedback but don't know if I should wait for it to get addressed or not. |
|
Nothing needs to get addressed, good to go |
7 participants
Backport of #90049 to release/8.0
/cc @mikelle-rogers
Customer Impact
R2R deoptimization while debugging doesn't happen properly with out this fix. If the customer were to step into R2R code without this fix, the debugger does not stop in the method like it should. This fix allows deoptimization of a method before it is jitted, which results in the debugger stopping in the R2R method when a customer steps into it.
We also audited the codepaths that deal with native code addresses and made sure they behaved appropriately when we have generics and/or deoptimized code.
Testing
It has been manually verified that these commits fix the error.
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.