Skip to content

[QUIC] Improve checking WritesClosed #92580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2023
Merged

[QUIC] Improve checking WritesClosed #92580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/QuicStreamTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1509,8 +1509,16 @@ async ValueTask WaitingSide(QuicStream stream, Task<long?> task, long errorCode)
{
// Writes must be closed, but whether successfully or not depends on the timing.
// Peer might have aborted reading side before receiving all the data.
// Manicka TODO await writes closed
Assert.True(stream.WritesClosed.IsCompleted);
try
{
await stream.WritesClosed.WaitAsync(TimeSpan.FromSeconds(5));
Copy link
Member

@rzikm rzikm Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the await always throw in this case? Or is it nondeterministic?

Copy link
Member Author

@ManickaP ManickaP Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-deterministics as the comment above explains. It depends on timing of the peer, dispose might be called before all the data arrived ==> abort, or after ==> success. This is not just because we buffer the data, MsQuic has it's own layer of buffering that behaves the same way.

}
catch (Exception ex)
{
QuicException qe = Assert.IsType<QuicException>(ex);
Assert.Equal(QuicError.StreamAborted, qe.QuicError);
Assert.Equal(errorCode, qe.ApplicationErrorCode);
}
}
}
}
Expand Down