`Convert.ToHexStringLower`: lower variant for `Convert.ToHexString` #92483

determ1ne · 2023-09-22T15:36:34Z

New methods:

namespace System
{
    public static class Convert
    {
        public static string ToHexStringLower(byte[] inArray);
        public static string ToHexStringLower(byte[] inArray, int offset, int length);
        public static string ToHexStringLower(ReadOnlySpan<byte> bytes);
    }
}

Close #60393.

TryToHexStringLower may be implemented after #86556 merged.

dotnet-issue-labeler · 2023-09-22T15:36:40Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

determ1ne · 2023-09-22T15:37:26Z

@dotnet-policy-service agree

stephentoub · 2023-09-22T15:49:11Z

It'd be good to include in this PR updates to places elsewhere in the repo we can switch to using the new public API, e.g.

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs

Line 233 in 0841678

    
           return HexConverter.ToString(hashBuffer.Slice(0, written), HexConverter.Casing.Lower);

vcsjones · 2023-09-22T16:07:49Z

~~The final approved API has additional overloads. See @bartonjs's comment here: #60393 (comment). It would be good to get TryToHexStringLower with the rest of them.~~

Nevermind I see that is addressed here:

TryToHexStringLower may be implemented after #86556 merged.

ghost · 2023-09-22T16:08:14Z

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

New methods:

namespace System
{
    public static class Convert
    {
        public static string ToHexStringLower(byte[] inArray);
        public static string ToHexStringLower(byte[] inArray, int offset, int length);
        public static string ToHexStringLower(ReadOnlySpan<byte> bytes);
    }
}

Close #60393.

TryToHexStringLower may be implemented after #86556 merged.

Author:	determ1ne
Assignees:	-
Labels:	`area-System.Runtime`, `new-api-needs-documentation`, `community-contribution`
Milestone:	-

buyaa-n · 2023-10-22T20:32:12Z

It'd be good to include in this PR updates to places elsewhere in the repo we can switch to using the new public API, e.g.

runtime/src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/AuthenticationHelper.Digest.cs

Line 233 in 0841678

return HexConverter.ToString(hashBuffer.Slice(0, written), HexConverter.Casing.Lower);

@determ1ne could you apply the feedback? In addition to above case, I see 5 hits in:

runtime/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs

Line 1785 in 52bd95c

    
           return new ActivityTraceId(HexConverter.ToString(idData, HexConverter.Casing.Lower));

and one hit in:

runtime/src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXmlDebugLog.cs

Line 200 in 52bd95c

return HexConverter.ToString(bytes, HexConverter.Casing.Lower);

Otherwise, the PR looks good, thank you!

determ1ne · 2023-10-28T07:38:20Z

@stephentoub, @buyaa-n I tried to patch all HexConverter.ToString to Convert.ToHexString or Convert.ToHexStringLower, please check if the new commit is appropriate.

buyaa-n · 2023-10-30T16:41:31Z

@stephentoub, @buyaa-n I tried to patch all HexConverter.ToString to Convert.ToHexString or Convert.ToHexStringLower, please check if the new commit is appropriate.

Thanks, looks good to me, you have got a conflict in src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicTlsSecret.cs

Close #60393.

TryToHexStringLower may be implemented after #86556 merged.

This should be contributing to #60393 not closing, should be closed when TryToHexStringLower implemented

determ1ne · 2023-11-14T10:33:50Z

@buyaa-n I've implemented Convert.TryToHexStringLower and the commits were rebased.

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs

src/libraries/System.Private.CoreLib/src/System/Convert.cs

src/libraries/System.Runtime/ref/System.Runtime.cs

...libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.ToHexString.cs

`System.Diagnostics.DiagnosticSource`

src/libraries/System.Private.CoreLib/src/System/Convert.cs

buyaa-n · 2023-11-17T19:46:44Z

src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Utils.cs

+#if NET5_0_OR_GREATER
+        internal static string EncodeHexString(byte[] sArray)
+        {
+            return Convert.ToHexString(sArray);
+        }
+#else
        internal static string EncodeHexString(byte[] sArray)
        {
            return HexConverter.ToString(sArray);
        }
+#endif


This doesn't seem need an if-def, it was added same time as Convert.ToHexString(...) added, was it failing in other builds?

Suggested change

#if NET5_0_OR_GREATER

internal static string EncodeHexString(byte[] sArray)

{

return Convert.ToHexString(sArray);

}

#else

internal static string EncodeHexString(byte[] sArray)

{

return HexConverter.ToString(sArray);

}

#endif

internal static string EncodeHexString(byte[] sArray)

{

return Convert.ToHexString(sArray);

}

From nuget the System.Security.Cryptography.Xml 8.0.0 package is still targeting .net framework, while Convert.ToHexString is added in net5.0, so I'm not sure if it will build (or works).

Please check the CI result https://github.com/dotnet/runtime/pull/92483/checks?check_run_id=18807551051 , removing the if-def will fail the build.

Thanks for checking, the file doesn't included in .netframework build, probably failing on netstandard

src/libraries/System.Security.Cryptography.Pkcs/src/Internal/Cryptography/PkcsHelpers.cs

...s/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXmlDebugLog.cs

This reverts commit 1dc62ae.

buyaa-n

LGMT, thank you @determ1ne ,

The failure unrelated and known.

cincuranet · 2023-11-21T17:51:29Z

Improvements in System.Diagnostics.Perf_Activity.ActivityAllocations (the only suspect in diff):

[Perf] Linux/x64: 5 Improvements on 11/20/2023 6:28:42 AM perf-autofiling-issues#24761
[Perf] Windows/x64: 1 Improvement on 11/20/2023 6:28:42 AM perf-autofiling-issues#25099
[Perf] Linux/x64: 1 Improvement on 11/20/2023 6:28:42 AM perf-autofiling-issues#25061
[Perf] Windows/x64: 1 Improvement on 11/20/2023 6:28:42 AM perf-autofiling-issues#25050
[Perf] Linux/arm64: 1 Improvement on 11/20/2023 6:28:42 AM perf-autofiling-issues#25194

dotnet-issue-labeler bot added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Sep 22, 2023

ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 22, 2023

determ1ne mentioned this pull request Sep 22, 2023

[API Proposal]: Add lowercase support for Convert.ToHexString #60393

Closed

vcsjones added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 22, 2023

adamsitnik added the needs-author-action An issue or pull request that requires more info or actions from the author. label Oct 27, 2023

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Oct 28, 2023

adamsitnik added the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 2, 2023

determ1ne force-pushed the feat-tohexstring-lower branch from a221e20 to 73ee107 Compare November 14, 2023 10:30

ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Nov 14, 2023

buyaa-n reviewed Nov 15, 2023

View reviewed changes

src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs Show resolved Hide resolved

buyaa-n reviewed Nov 15, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Convert.cs Outdated Show resolved Hide resolved

buyaa-n reviewed Nov 15, 2023

View reviewed changes

src/libraries/System.Runtime/ref/System.Runtime.cs Show resolved Hide resolved

buyaa-n reviewed Nov 15, 2023

View reviewed changes

...libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/Convert.ToHexString.cs Show resolved Hide resolved

determ1ne added 6 commits November 16, 2023 20:24

Add System.Convert.ToHexStringLower with tests

e2d3897

fix typo

73e0be6

Use new public API Convert.ToHexStringLower

0d55d0c

Add Convert.TryToHexStringLower

8ba2f89

format code

3356999

sort methods

07f6c56

determ1ne added 4 commits November 16, 2023 20:24

use old HexConverter API on

32a7d93

`System.Diagnostics.DiagnosticSource`

Add unit test for Convert.TryToHexStringLower

c7c9179

bug fix

9f43dbd

add if-defs for libs

660890f

determ1ne force-pushed the feat-tohexstring-lower branch from dca0505 to 660890f Compare November 16, 2023 12:42

This was referenced Nov 16, 2023

System.Data.OleDb.Tests timeout in net48 x86 Release leg #87783

Open

Test timeout in System.Security.Cryptography.OpenSsl.Tests on mono Amd64 OSX #94436

Closed

buyaa-n reviewed Nov 17, 2023

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Convert.cs Outdated Show resolved Hide resolved

buyaa-n reviewed Nov 17, 2023

View reviewed changes

src/libraries/System.Security.Cryptography.Pkcs/src/Internal/Cryptography/PkcsHelpers.cs Show resolved Hide resolved

buyaa-n reviewed Nov 17, 2023

View reviewed changes

...s/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/SignedXmlDebugLog.cs Show resolved Hide resolved

determ1ne added 3 commits November 18, 2023 12:54

removed whitespace

e56b06a

TEST: test if Convert.ToHexString works without if-def

1dc62ae

Revert "TEST: test if Convert.ToHexString works without if-def"

a5609b5

This reverts commit 1dc62ae.

build-analysis bot mentioned this pull request Nov 18, 2023

DisabledRuntimeMarshalling.PInvokeAssemblyMarshallingEnabled.DelegatesFromExternalAssembly.StructWithDefaultNonBlittableFields() failing #94931

Closed

buyaa-n approved these changes Nov 20, 2023

View reviewed changes

buyaa-n merged commit b80a4fd into dotnet:main Nov 20, 2023
174 of 176 checks passed

github-actions bot locked and limited conversation to collaborators Dec 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Convert.ToHexStringLower`: lower variant for `Convert.ToHexString` #92483

`Convert.ToHexStringLower`: lower variant for `Convert.ToHexString` #92483

determ1ne commented Sep 22, 2023

dotnet-issue-labeler bot commented Sep 22, 2023

determ1ne commented Sep 22, 2023

stephentoub commented Sep 22, 2023

vcsjones commented Sep 22, 2023 •

edited

Loading

ghost commented Sep 22, 2023

buyaa-n commented Oct 22, 2023

determ1ne commented Oct 28, 2023

buyaa-n commented Oct 30, 2023

determ1ne commented Nov 14, 2023

buyaa-n Nov 17, 2023

determ1ne Nov 18, 2023

determ1ne Nov 18, 2023

buyaa-n Nov 20, 2023

buyaa-n left a comment •

edited

Loading

cincuranet commented Nov 21, 2023 •

edited

Loading

Convert.ToHexStringLower: lower variant for Convert.ToHexString #92483

Convert.ToHexStringLower: lower variant for Convert.ToHexString #92483

Conversation

determ1ne commented Sep 22, 2023

dotnet-issue-labeler bot commented Sep 22, 2023

determ1ne commented Sep 22, 2023

stephentoub commented Sep 22, 2023

vcsjones commented Sep 22, 2023 • edited Loading

ghost commented Sep 22, 2023

buyaa-n commented Oct 22, 2023

determ1ne commented Oct 28, 2023

buyaa-n commented Oct 30, 2023

determ1ne commented Nov 14, 2023

buyaa-n Nov 17, 2023

Choose a reason for hiding this comment

determ1ne Nov 18, 2023

Choose a reason for hiding this comment

determ1ne Nov 18, 2023

Choose a reason for hiding this comment

buyaa-n Nov 20, 2023

Choose a reason for hiding this comment

buyaa-n left a comment • edited Loading

Choose a reason for hiding this comment

cincuranet commented Nov 21, 2023 • edited Loading

`Convert.ToHexStringLower`: lower variant for `Convert.ToHexString` #92483

`Convert.ToHexStringLower`: lower variant for `Convert.ToHexString` #92483

vcsjones commented Sep 22, 2023 •

edited

Loading

buyaa-n left a comment •

edited

Loading

cincuranet commented Nov 21, 2023 •

edited

Loading