[release/8.0-rc2] Ensure that embedded broadcast checks the base type of the parent node #92459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #92414 to release/8.0-rc2 /cc @tannergooding Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
tannergooding
added
the
Servicing-consider
|
@tannergooding Please send an approval request email to Tactics and get a code review sign-off. Today's the last day for merging RC2 backports. |
jakobbotsch
approved these changes
Sep 22, 2023
carlossanlop
added
Servicing-approved
|
Approved by Tactics via email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92414 to release/8.0-rc2
/cc @tannergooding
Customer Impact
Developers would see incorrect codegen when using a vector broadcast whose size mismatched the operation width on hardware that had AVX-512 support.
Testing
Explicit tests were added covering both smaller and larger than expected vector broadcasts.
Risk
Low. This only impacts customers with AVX-512 capable hardware and is fixing net new functionality in .NET 8