Ensure Bind can handle null from GetSection

[ericstj]

Fixes #92213

IConfiguration instances may return a null value from GetSection. We were not handling this and would throw a NullReferenceException.

[ghost]

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Fixes #92213

IConfiguration instances may return a null value from GetSection. We were not handling this and would throw a NullReferenceException.

Author:	ericstj
Assignees:	ericstj
Labels:	area-Extensions-Configuration
Milestone:	-

[ericstj]

Previously the entire block below was wrapped in a null check - 35f043f#diff-2e6f75e1d4f577e1c8c1b6a32d158ce7812a38ad8fcd3b4d762157b92c03e890L308-R315

Since this method already has multiple returns, I find it more readable to early-exit rather than count curly-brackets/indentation.

[tarekgh]

sounds good to me.

[RussKie]

Thank you!

[tarekgh]

Added minor comment/suggestion, LGTM otherwise. Thanks for fixing this.

[ericstj]

@RussKie - if you wanted to workaround this you can register a mock section as the default return value for GetSection as follows:

mockConfSection.Setup(m => m.GetSection(It.IsAny<string>())).Returns(emptySection.Object);

That would ensure that GetSection doesn't return null. We definitely want to fix this though, since it's a regression.

[RussKie]

@RussKie Igor Velikorossov FTE - if you wanted to workaround this you can register a mock section as the default return value for GetSection as follows:

mockConfSection.Setup(m => m.GetSection(It.IsAny<string>())).Returns(emptySection.Object);

That would ensure that GetSection doesn't return null. We definitely want to fix this though, since it's a regression.

👍

[ericstj]

Remaining legs are outer loop build incorrectly triggered for all PRs

[ericstj]

/backport to release/8.0

[github-actions]

Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6268341143

[ericstj]

/backport to release/8.0-rc2

[github-actions]

Started backporting to release/8.0-rc2: https://github.com/dotnet/runtime/actions/runs/6275041479