[release/8.0-rc2] Fix the VN for xor operation #92372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #91503 to release/8.0-rc2 /cc @kunalspathak Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
kunalspathak
added
the
Servicing-consider
|
@jeffschwMSFT @dotnet/jit-contrib |
jakobbotsch
approved these changes
Sep 20, 2023
jeffschwMSFT
approved these changes
Sep 20, 2023
|
@carlossanlop @ViktorHofer @ericstj - can we merge this? |
jeffschwMSFT
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91503 to release/8.0-rc2
/cc @kunalspathak
Customer Impact
For a XOR operation with Vector64/Vector128/Vector256, we would return wrong result leading to functional incorrectness. This was recently reported by a customer in #92328.
Fixes: #92328
Testing
Added test case and CI test.
Risk
Low, this is a one line typo fix.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.