[release/8.0-rc2] Fixes for LLVM AOT on Windows from @lateralusX #92365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
SamMonoRT,
lambdageek and
vargaz
as code owners
ghost
added
the
steveisok
added
Servicing-consider
steveisok
approved these changes
Sep 21, 2023
|
Approved over email by tactics. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92356 to release/8.0-rc2
/cc @directhex
Customer Impact
Reported in #92031, a customer was unable to build after selecting the
Use LLVM optimising compileroption on android. This is due to our aot compiler not including the exe extension when shelling out to the LLVM toolopt.exe.Testing
Validated locally - this is a gap in test coverage, which we will plug in #92376
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.