-
Couldn't load subscription status.
- Fork 5.2k
Fix downlevel build break in TensorPrimitives #92269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/backport to release/8.0 |
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue Detailsnull
|
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6235610540 |
|
This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include |
|
Hmm, this seems to have added prebuilts.
Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend? |
|
I see, here's what we do for the other frameworks; Lines 93 to 98 in d3da653
I'll condition out the 6.0 and 7.0 so they aren't there for source build. |
|
Thanks for the additional tweaks, @ericstj. |
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?
.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.
Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15
System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.
No description provided.