Skip to content

Conversation

@stephentoub
Copy link
Member

No description provided.

@stephentoub
Copy link
Member Author

/backport to release/8.0

@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: stephentoub
Assignees: -
Labels:

area-System.Numerics

Milestone: -

@github-actions
Copy link
Contributor

@ericstj
Copy link
Member

ericstj commented Sep 19, 2023

This needs more based on the changes I have in 8.0. Should we bring those here too? Maybe it makes sense to include net6.0 in main so you have coverage of the frameworks building in 8.0.

@ericstj
Copy link
Member

ericstj commented Sep 19, 2023

Hmm, this seems to have added prebuilts.

error : 2 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.NETCore.App.Ref.6.0.20 Microsoft.NETCore.App.Ref.7.0.9

Maybe we should avoid building against 6.0 and 7.0 when building in sourcebuild? @mthalman what do you reccomend?

@ericstj
Copy link
Member

ericstj commented Sep 19, 2023

I see, here's what we do for the other frameworks;

<NetCoreAppPrevious Condition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppPrevious>
<!-- The minimum supported .NET version. -->
<NetCoreAppMinimum>net6.0</NetCoreAppMinimum>
<NetCoreAppMinimum Condition="'$(DotNetBuildFromSource)' == 'true'">$(NetCoreAppCurrent)</NetCoreAppMinimum>

I'll condition out the 6.0 and 7.0 so they aren't there for source build.

@ericstj ericstj merged commit 32c3355 into dotnet:main Sep 20, 2023
@stephentoub stephentoub deleted the fixdownleveltensor branch September 20, 2023 13:43
@stephentoub
Copy link
Member Author

Thanks for the additional tweaks, @ericstj.


<PropertyGroup>
<TargetFrameworks>$(NetCoreAppCurrent);$(NetCoreAppPrevious);$(NetCoreAppMinimum);netstandard2.0;$(NetFrameworkMinimum)</TargetFrameworks>
<TargetFrameworks Condition="'$(DotNetBuildFromSource)' != 'true'">$(TargetFrameworks);net7.0;net6.0</TargetFrameworks>
Copy link
Member

@ViktorHofer ViktorHofer Oct 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw this PR. I don't see an underlying issue that is fixed by this change, what was the motivation to add net7.0 and net6.0 TFMs to this library?

.NET 9 dotnet/runtime libraries packages support net8.0 (NetMinimum) and net9.0 (NetCurrent) only.

Looking at the latest package from main, I see that a warning is emitted at consumption time when targeting net6.0 or net7.0: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet9/NuGet/System.Numerics.Tensors/overview/9.0.0-alpha.1.23519.15

System.Numerics.Tensors 9.0.0-alpha.1.23519.15 doesn't support net7.0 and has not been tested with it. Consider upgrading your TargetFramework to net8.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk.

@ghost ghost locked as resolved and limited conversation to collaborators Nov 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants