[release/8.0] Use strategy in StrategyBasedComWrappers.ComputeVtables #92250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't actually use the strategy object here, so users like WinForms can't actually use it.
…e/InteropServices/Marshalling/StrategyBasedComWrappers.cs Co-authored-by: Jackson Schuster <[email protected]>
ghost
added
the
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsBackport of #92085 to release/8.0 /cc @jkoritzinsky Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jkoritzinsky
requested review from
AaronRobinsonMSFT,
agocke,
elinor-fung and
jeffschwMSFT
jkoritzinsky
added
the
Servicing-consider
elinor-fung
approved these changes
Sep 18, 2023
jeffschwMSFT
added
Servicing-approved
|
Wow the CI is taking forever on this PR 😢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92085 to release/8.0
/cc @jkoritzinsky
Customer Impact
Customers cannot customize CCW behavior as designed in source-generated COM interop.
Testing
Validated with unit tests.
Risk
Low risk. The change just calls a method that ends up doing the exact same behavior as today.