[release/8.0] [NativeAOT] Fix iOS library build by linking standard C++ library by default #92141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested a review
from MichalStrehovsky
as a code owner
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsBackport of #92114 to release/8.0 /cc @ivanpovazan Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
SamMonoRT
approved these changes
Sep 15, 2023
marek-safar
approved these changes
Sep 16, 2023
|
The original PR has been merged to main via: fa1bf3c |
SamMonoRT
added
Servicing-approved
|
cc @carlossanlop - this is ready to be merged. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #92114 to release/8.0
/cc @ivanpovazan
Customer Impact
This fixes a regression introduced in RC1 release which resulted in build failures when building an iOS library with NativeAOT build integration targets (originally reported here: #91997).
Testing
CI should verify this change does not introduce a regression.
Additionally, building an iOS library with NativeAOT was manually tested and verified that it works.
Risk
Low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.