[release/8.0] [nodejs] Remove experimental wasm arguments from template #91401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
kg,
lewing,
pavelsavara and
radical
as code owners
ghost
added
the
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #91384 to release/8.0 /cc @maraf Customer ImpactCustomers using newer Node won't need to remove unsupported parameters from the template. For customers with older Node we have a user friendly error message with link to guidance. TestingManual. RiskLow. IMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@lewing do you approve? |
carlossanlop
added
the
Servicing-consider
lewing
approved these changes
Aug 31, 2023
marek-safar
approved these changes
Sep 1, 2023
carlossanlop
added
Servicing-approved
|
CI failure is #90639 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91384 to release/8.0
/cc @maraf
Customer Impact
Customers using newer Node won't need to remove unsupported parameters from the template. For customers with older Node we have a user friendly error message with link to guidance.
Testing
Manual.
Risk
Low.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.