Skip to content

[release/8.0] Add Retry and Task.Delay to WinHttpHandler AfterReadResponseServerError_ClientWrite test #91271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2023
Merged

[release/8.0] Add Retry and Task.Delay to WinHttpHandler AfterReadResponseServerError_ClientWrite test #91271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c79a093
Add Task.Delay to give more time for reset frame
liveans Aug 18, 2023
703e06e
Apply James' solution
liveans Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion ...ibraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/BidirectionStreamingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,17 @@ public async Task AfterReadResponseServerError_ClientWrite()
// Server sends RST_STREAM.
await connection.WriteFrameAsync(new RstStreamFrame(FrameFlags.EndStream, 0, streamId));

await Assert.ThrowsAsync<IOException>(() => requestStream.WriteAsync(new byte[50]).AsTask());
await Assert.ThrowsAsync<IOException>(async () =>
{
for (int i = 0; i < 10; i++)
{
await requestStream.WriteAsync(new byte[50]);

// WriteAsync succeeded because handler hasn't processed RST_STREAM yet.
// Small wait before trying again.
await Task.Delay(50);
}
});
}
}

Expand Down