Use live illink to trim framework #91233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
Also prevent build-native.proj from importing illink.targets.
ViktorHofer
reviewed
Aug 29, 2023
ViktorHofer
reviewed
Aug 29, 2023
ViktorHofer
reviewed
Aug 29, 2023
- Don't reference ILLink.Tasks from subsets - Use PackageReference from illink.tasks - Import props from source directory Add extensibility to shipping targets to make this possible. - Set IsSourceProject false for .proj files
ViktorHofer
reviewed
Aug 29, 2023
ViktorHofer
reviewed
Aug 29, 2023
Avoid needing to reorganize SDK imports
ViktorHofer
reviewed
Aug 30, 2023
Co-authored-by: Viktor Hofer <[email protected]>
|
@sbomer I pushed one more commit to your branch to make sure that the tools build with the correct configuration when building from root. EDIT: Pushed one more as paths weird displayed weirdly in binlogs: 
|
ViktorHofer
approved these changes
Aug 31, 2023
We agreed on (at least under src/libraries) to use the Windows directory separator char `\` instead of a forward slash. This helps when looking at binlogs as those then correctly display a path.
|
Built your changes locally with a mixed set of configurations: |
|
This looks like it may be breaking the official build https://dev.azure.com/dnceng/internal/_build/results?buildId=2257152&view=results |
|
Seems to be NativeAOT legs only. |
|
Fix is here: #91454 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#90517 added a workaround to trim the framework using the SDK's version of ILLink.Tasks (see #90517 (comment) for context). This removes the workaround and replaces it with logic to use the live build of ILLink.Tasks.
The dependency on ILLink.Tasks is expressed via a magical
ProjectReferencethat @ViktorHofer kindly helped me construct.Unfortunately I had to add a small extension point to
Microsoft.NET.ILLink.Tasks.props, to allow overriding the analyzer props path. This lets it be imported right out of the source tree, instead of from the build output of ILLink.Tasks.