Skip to content

[release/8.0] [NativeAOT] Fix --make-repro-path ILC option #90989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2023
Merged

[release/8.0] [NativeAOT] Fix --make-repro-path ILC option #90989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9721938
Fix --make-repro-path option
ivanpovazan Aug 22, 2023
15ca73a
Merge branch 'release/8.0' into backport/pr-90935-to-release/8.0
jkotas Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/coreclr/tools/Common/CommandLineHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ public static void MakeReproPackage(string makeReproPath, string outputFilePath,
foreach (CliOption option in res.CommandResult.Command.Options)
{
OptionResult optionResult = res.GetResult(option);
if (optionResult is null || option.Name == "make-repro-path")
if (optionResult is null || option.Name == "--make-repro-path")
{
continue;
}
Expand All @@ -233,15 +233,15 @@ public static void MakeReproPackage(string makeReproPath, string outputFilePath,
}
foreach (string inputFile in dictionary.Values)
{
rspFile.Add($"--{option.Name}:{ConvertFromOriginalPathToReproPackagePath(input: true, inputFile)}");
rspFile.Add($"{option.Name}:{ConvertFromOriginalPathToReproPackagePath(input: true, inputFile)}");
}
}
else
{
foreach (string optInList in values)
{
if (!string.IsNullOrEmpty(optInList))
rspFile.Add($"--{option.Name}:{optInList}");
rspFile.Add($"{option.Name}:{optInList}");
}
}
}
Expand All @@ -254,11 +254,11 @@ public static void MakeReproPackage(string makeReproPath, string outputFilePath,
// if output option is used, overwrite the path to the repro package
stringVal = ConvertFromOriginalPathToReproPackagePath(input: false, stringVal);
}
rspFile.Add($"--{option.Name}:{stringVal}");
rspFile.Add($"{option.Name}:{stringVal}");
}
else
{
rspFile.Add($"--{option.Name}:{val}");
rspFile.Add($"{option.Name}:{val}");
}
}
}
Expand Down