Skip to content

[release/8.0] Bring AggressiveOptimization back on AwaitUnsafeOnCompleted #90980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2023
Merged

[release/8.0] Bring AggressiveOptimization back on AwaitUnsafeOnCompleted #90980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ies/System.Private.CoreLib/src/System/Runtime/CompilerServices/AsyncTaskMethodBuilderT.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ internal static void AwaitUnsafeOnCompleted<TAwaiter, TStateMachine>(
AwaitUnsafeOnCompleted(ref awaiter, box);
}

// Tier0 codegen for this function may still allocate (while FullOpts won't).
// TODO: remove once https://github.com/dotnet/runtime/issues/90965 is implemented
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
internal static void AwaitUnsafeOnCompleted<TAwaiter>(
ref TAwaiter awaiter, IAsyncStateMachineBox box)
where TAwaiter : ICriticalNotifyCompletion
Expand Down