Skip to content

[release/8.0] Error out when NativeLib has EventPipe enabled #90934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Merge #91634 into release/8.0-staging
merged 3 commits into from
Aug 22, 2023
Merged

[release/8.0] Error out when NativeLib has EventPipe enabled #90934

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53f0fe6
Error out when NativeLib has EventPipe enabled
LakshanF Aug 18, 2023
1ac34f0
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
LakshanF Aug 18, 2023
05d0e07
Update src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Nativ…
LakshanF Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Publish.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
Text="RuntimeIdentifier is required for native compilation. Try running dotnet publish with the -r option value specified." />
<Error Condition="'$(GeneratePackageOnBuild)' == 'true'" Text="GeneratePackageOnBuild is not supported for native compilation." />
<Error Condition="'$(OutputType)' != 'Library' and '$(NativeLib)' != '' and '$(CustomNativeMain)' != 'true'" Text="NativeLib requires OutputType=Library." />
<!-- See https://github.com/dotnet/runtime/issues/89346 for details -->
<Error Condition="'$(NativeLib)' != '' and '$(EventSourceSupport)' == 'true'" Text="EventSource is not supported when compiling to a native library. Set EventSourceSupport to false." />

<Error Condition="'$(PublishTrimmed)' == 'false'" Text="PublishTrimmed is implied by native compilation and cannot be disabled." />

Expand Down