Skip to content

[main] Change OneLocBuild mirror branch to release/8.0 temporarily #90812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2023
+7 −7
Merged

[main] Change OneLocBuild mirror branch to release/8.0 temporarily #90812

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbb4a71
[main] Change OneLocBuild mirror branch to release/8.0 temporarily
carlossanlop Aug 18, 2023
53b3388
Re-enable OneLocBuild in runtime-official.yml
carlossanlop Aug 18, 2023
d05c877
Do not modify common, add the parameter in the uncommented lines inst…
carlossanlop Aug 18, 2023
f3d2b1e
Revert spacing
carlossanlop Aug 18, 2023
7cbdd60
Change condition
carlossanlop Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions eng/common/templates/job/onelocbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ parameters:

# Optional: A defined YAML pool - https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=vsts&tabs=schema#pool
pool: ''

CeapexPat: $(dn-bot-ceapex-package-r) # PAT for the loc AzDO instance https://dev.azure.com/ceapex
Copy link
Member

@ericstj ericstj Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You cannot change things in the common folder. The contents of this folder are copied verbatim from dotnet/arcade.

GithubPat: $(BotAccount-dotnet-bot-repo-PAT)

Expand All @@ -21,13 +21,13 @@ parameters:
RepoType: gitHub
GitHubOrg: dotnet
MirrorRepo: ''
MirrorBranch: main
MirrorBranch: release/8.0
condition: ''
JobNameSuffix: ''

jobs:
- job: OneLocBuild${{ parameters.JobNameSuffix }}

dependsOn: ${{ parameters.dependsOn }}

displayName: OneLocBuild${{ parameters.JobNameSuffix }}
Expand Down
13 changes: 6 additions & 7 deletions eng/pipelines/runtime-official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,12 @@ extends:
# Localization build
#

# disabled due to https://github.com/dotnet/runtime/issues/90466
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is still broken or not. Make sure you are able to test this PR before merging. I don't think your PR validation build will test it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's an azp run command to run it. Should I re-enable that in a separate PR?

Copy link
Contributor Author

@carlossanlop carlossanlop Aug 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, your other comment suggesting adding the parameter is precisely the lines I uncommented. It should be done in this same PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still won't run in PR validation. It only runs for official builds. Also the branch filter might be getting in the way regardless. Might be hard to test this.

#- ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/main') }}:
# - template: /eng/common/templates/job/onelocbuild.yml
# parameters:
# MirrorRepo: runtime
# LclSource: lclFilesfromPackage
# LclPackageId: 'LCL-JUNO-PROD-RUNTIME'
- ${{ if eq(variables['Build.SourceBranch'], 'refs/heads/main') }}:
- template: /eng/common/templates/job/onelocbuild.yml
parameters:
MirrorRepo: runtime
LclSource: lclFilesfromPackage
LclPackageId: 'LCL-JUNO-PROD-RUNTIME'

#
# Source Index Build
Expand Down