PEImage should not permit m_path field mutation
#90753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
changed the title
PEImage should no longer share ref to fieldPEImage should no longer expose ref to m_path field
AaronRobinsonMSFT
changed the title
PEImage should no longer expose ref to m_path fieldPEImage should not expose ref to m_path field
jkotas
reviewed
Aug 17, 2023
This was referenced Aug 17, 2023
jkotas
reviewed
Aug 18, 2023
Create m_pathHash field and remove function. Remove FEATURE_CASE_SENSITIVE_FILESYSTEM.
AaronRobinsonMSFT
force-pushed
the
peimage_remove_mutable_path
branch
from
7bff8fa to
e0b9c07
Compare
jkotas
reviewed
Aug 23, 2023
AaronRobinsonMSFT
changed the title
PEImage should not expose ref to m_path fieldPEImage should not permit m_path field mutation
jkotas
reviewed
Aug 23, 2023
|
tvos failure is unrelated. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5967333380 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90657
Remove cases where
PEImage::m_pathwas mutated.Create
m_pathHashfield and remove function.Remove
FEATURE_CASE_SENSITIVE_FILESYSTEM.