Improve profiled casts #2

[EgorBo]

Small clean up + adds new patterns to recognize, e.g.:

class Prog
{
    static void Main()
    {
        for (int i = 0; i < 200; i++)
        {
            Test1<int>(new int[10]);
            Test2(new uint[10]);
            Thread.Sleep(16);
        }
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    // NOTE: won't kick in for shared T
    static bool Test1<T>(object o) => o is IEnumerable<T>;

    [MethodImpl(MethodImplOptions.NoInlining)]
    static bool Test2(object o) => o is int[];
}

Old codegen:

; Assembly listing for method Prog:Test1
       sub      rsp, 40
       mov      rdx, rcx
       mov      rcx, 0x7FF955C08F70      ; IEnumerable`1[int]
       call     [CORINFO_HELP_ISINSTANCEOFANY]
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 37


; Assembly listing for method Prog:Test2
       sub      rsp, 40
       mov      rdx, rcx
       mov      rcx, 0x7FF955718230      ; int[]
       call     [CORINFO_HELP_ISINSTANCEOFARRAY]
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 37

New codegen:

; Assembly listing for method Prog:Test1
       sub      rsp, 40
       mov      rax, rcx
       test     rax, rax
       je       SHORT G_M13683_IG05
       mov      rdx, 0x7FF955728230      ; int[]
       cmp      qword ptr [rax], rdx
       je       SHORT G_M13683_IG05
       mov      rdx, rcx
       mov      rcx, 0x7FF955BBAAD0      ; IEnumerable`1[int]
       call     CORINFO_HELP_ISINSTANCEOFANY
G_M13683_IG05:
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 59


; Assembly listing for method Prog:Test2
       sub      rsp, 40
       mov      rax, rcx
       test     rax, rax
       je       SHORT G_M19173_IG05
       mov      rdx, 0x7FF955DC59E0      ; uint[]
       cmp      qword ptr [rax], rdx
       je       SHORT G_M19173_IG05
       mov      rdx, rcx
       mov      rcx, 0x7FF955748230      ; int[]
       call     CORINFO_HELP_ISINSTANCEOFARRAY
G_M19173_IG05:
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 59

castclass is also improved.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Small clean up + adds new patterns to recognize, e.g.:

class Prog
{
    static void Main()
    {
        for (int i = 0; i < 200; i++)
        {
            Test1<int>(new int[10]);
            Test2(new uint[10]);
            Thread.Sleep(16);
        }
    }

    [MethodImpl(MethodImplOptions.NoInlining)]
    // NOTE: won't kick in for shared T
    static bool Test1<T>(object o) => o is IEnumerable<T>;

    [MethodImpl(MethodImplOptions.NoInlining)]
    static bool Test2(object o) => o is int[];
}

Old codegen:

; Assembly listing for method Prog:Test1
       sub      rsp, 40
       mov      rdx, rcx
       mov      rcx, 0x7FF955C08F70      ; IEnumerable`1[int]
       call     [CORINFO_HELP_ISINSTANCEOFANY]
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 37


; Assembly listing for method Prog:Test2
       sub      rsp, 40
       mov      rdx, rcx
       mov      rcx, 0x7FF955718230      ; int[]
       call     [CORINFO_HELP_ISINSTANCEOFARRAY]
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 37

New codegen:

; Assembly listing for method Prog:Test1
       sub      rsp, 40
       mov      rax, rcx
       test     rax, rax
       je       SHORT G_M13683_IG05
       mov      rdx, 0x7FF955728230      ; int[]
       cmp      qword ptr [rax], rdx
       je       SHORT G_M13683_IG05
       mov      rdx, rcx
       mov      rcx, 0x7FF955BBAAD0      ; IEnumerable`1[int]
       call     CORINFO_HELP_ISINSTANCEOFANY
G_M13683_IG05:
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 59


; Assembly listing for method Prog:Test2
       sub      rsp, 40
       mov      rax, rcx
       test     rax, rax
       je       SHORT G_M19173_IG05
       mov      rdx, 0x7FF955DC59E0      ; uint[]
       cmp      qword ptr [rax], rdx
       je       SHORT G_M19173_IG05
       mov      rdx, rcx
       mov      rcx, 0x7FF955748230      ; int[]
       call     CORINFO_HELP_ISINSTANCEOFARRAY
G_M19173_IG05:
       test     rax, rax
       setne    al
       movzx    rax, al
       add      rsp, 40
       ret      
; Total bytes of code 59

Author:	EgorBo
Assignees:	EgorBo
Labels:	area-CodeGen-coreclr
Milestone:	-

[EgorBo]

/azp run runtime-coreclr pgo, runtime-coreclr libraries-pgo, runtime-coreclr pgostress

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[EgorBo]

PTAL @AndyAyersMS, I'm going to kick off a perf run with DOTNET_JitProfileCasts=1

[EgorBo]

Failure is #90593