Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Fix some errors after the kernel supporting SIMD. #90734

Merged
merged 1 commit into from
Aug 21, 2023
Merged

[LoongArch64] Fix some errors after the kernel supporting SIMD. #90734

merged 1 commit into from
Aug 21, 2023

Conversation

shushanhf
Copy link
Contributor

This PR is part of the issue #69705 to amend the LA's port.

Fix some errors after the kernel supporting SIMD.
Also preparing the context to implement the JIT-Intrinsics later.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 17, 2023
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 17, 2023
shushanhf
shushanhf commented Aug 17, 2023
View reviewed changes
Copy link
Contributor Author

@shushanhf shushanhf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT REVIEWED before updated it.

@teo-tsirpanis teo-tsirpanis added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 17, 2023
@ghost
Copy link

ghost commented Aug 17, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is part of the issue #69705 to amend the LA's port.

Fix some errors after the kernel supporting SIMD.
Also preparing the context to implement the JIT-Intrinsics later.

Author: shushanhf
Assignees: -
Labels:

area-CodeGen-coreclr, community-contribution, arch-loongarch64
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Aug 17, 2023
Closed
@shushanhf
Copy link
Contributor Author

Hi, @jakobbotsch

Could you please review this PR?
Thanks

@shushanhf
Copy link
Contributor Author

Hi, @jkotas
Could you please review this PR ?
Thanks!

jkotas
jkotas approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkotas jkotas merged commit d74b524 into dotnet:main Aug 21, 2023
107 of 109 checks passed
@shushanhf shushanhf deleted the la_simd_context branch August 21, 2023 01:20
@shushanhf
Copy link
Contributor Author

LGTM

Ｔｈａｎｋｓ～

@ghost ghost locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shushanhf @jkotas @teo-tsirpanis