-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch fx_ver_t::as_str from stringstream to append/to_string #90652
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsStop using On my local Windows x64 build, the sizes on disk were:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/5894030092 |
Stop using
std::stringstream
to convertfx_ver_t
to a string. It pulls instd::locale
(and other things) in all the host binaries when we really just need a simple conversion of the numbers to a string. In some binaries, it was also the only usage of stringstream. In theory, this should also be faster, although this is not a particularly perf-sensitive function (most usage is for when tracing is enabled).On my local Windows x64 build, the sizes on disk were: