Skip to content

Conversation

@BrennanConroy
Copy link
Member

Backport of #90285 to release/7.0-staging

Customer Impact

Rate limiting operations could deadlock in specific scenarios.

Testing

Manual testing and automated test with internal hooks added

Risk

Low. Issue was clear once pointed out.

@BrennanConroy BrennanConroy added Servicing-consider Issue for next servicing release review area-System.Threading labels Aug 10, 2023
@ghost ghost assigned BrennanConroy Aug 10, 2023
@ghost
Copy link

ghost commented Aug 10, 2023

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90285 to release/7.0-staging

Customer Impact

Rate limiting operations could deadlock in specific scenarios.

Testing

Manual testing and automated test with internal hooks added

Risk

Low. Issue was clear once pointed out.

Author: BrennanConroy
Assignees: -
Labels:

Servicing-consider, area-System.Threading

Milestone: -

@danmoseley danmoseley added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 15, 2023
@danmoseley
Copy link
Member

this was approved in email on 8/10

@danmoseley
Copy link
Member

@carlossanlop does @BrennanConroy merge now?

@carlossanlop
Copy link
Contributor

carlossanlop commented Aug 15, 2023

PR owners are free to merge whenever (in the staging branches), but just so you know, I already flowed everything from staging into internal. Do we absolutely need this in the October Release? If yes, then I'll have to flow this PR alone manually.

@carlossanlop
Copy link
Contributor

I mention the above because Code complete was yesterday for servicing, @danmoseley.

@BrennanConroy BrennanConroy merged commit c6a0434 into dotnet:release/7.0-staging Aug 15, 2023
@BrennanConroy BrennanConroy deleted the brecon/bp branch August 15, 2023 23:25
@carlossanlop
Copy link
Contributor

Since this was merged one day after code complete, it was too late and will have to wait until the next month to release it.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Threading Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants