-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ReceiveFromAsync and SendToAsync with SocketAddress overload #90086
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0351b15
cleanup
wfurt 60f5368
update
wfurt 3174f54
cleanup
wfurt 9e13405
feedback
wfurt b30bdd0
udpdate
wfurt b3f8a78
Merge branch 'main' of https://github.com/dotnet/runtime into receive…
wfurt 706f2a1
pal
wfurt 1d07472
windows
wfurt b341e5a
equals
wfurt 6f24e89
Merge branch 'main' of https://github.com/dotnet/runtime into receive…
wfurt acc9e83
Merge branch 'main' of https://github.com/dotnet/runtime into receive…
wfurt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
src/libraries/Common/src/System/Net/Internals/IPAddressExtensions.cs
This file was deleted.
Oops, something went wrong.
72 changes: 0 additions & 72 deletions
72
src/libraries/Common/src/System/Net/Internals/IPEndPointExtensions.cs
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
src/libraries/Common/src/System/Net/SocketAddressExtensions.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics; | ||
using System.Net; | ||
|
||
namespace System.Net.Sockets | ||
{ | ||
internal static partial class SocketAddressExtensions | ||
{ | ||
public static IPAddress GetIPAddress(this SocketAddress socketAddress) => IPEndPointExtensions.GetIPAddress(socketAddress.Buffer.Span); | ||
public static int GetPort(this SocketAddress socketAddress) | ||
{ | ||
Debug.Assert(socketAddress.Family == AddressFamily.InterNetwork || socketAddress.Family == AddressFamily.InterNetworkV6); | ||
return (int)SocketAddressPal.GetPort(socketAddress.Buffer.Span); | ||
} | ||
|
||
public static IPEndPoint GetIPEndPoint(this SocketAddress socketAddress) | ||
{ | ||
return new IPEndPoint(socketAddress.GetIPAddress(), socketAddress.GetPort()); | ||
} | ||
|
||
public static bool Equals(this SocketAddress socketAddress, EndPoint? endPoint) | ||
{ | ||
if (socketAddress.Family == endPoint?.AddressFamily && endPoint is IPEndPoint ipe) | ||
{ | ||
return ipe.Equals(socketAddress.Buffer.Span); | ||
} | ||
|
||
// We could serialize other EndPoints and compare socket addresses. | ||
// But that would do two allocations and is probably as expensive as | ||
// allocating new EndPoint. | ||
// This may change if https://github.com/dotnet/runtime/issues/78993 is done | ||
return false; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This broke
Socket.OSSupportsUnixDomainSockets
as Windows only support Stream for UDS.