Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Aug 4, 2023

Fixes #89937

@ghost ghost assigned jkotas Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #89937

Author: jkotas
Assignees: -
Labels:

area-NativeAOT-coreclr

Milestone: -

#include <asm/hwcap.h>

// Light-up for hardware capabilities that are not present in older headers used by the portable build.
#ifndef HWCAP_ASIMDRDM
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do similar light-up in other places, e.g. here:

// Ensure __NR_membarrier is defined for portable builds.

@jkotas jkotas requested a review from MichalStrehovsky August 4, 2023 02:56
Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not introduced by the unification with NativeAOT - it was a pre-existing issue, right? I see the HWCAP_LRCPC ifdefs in old jitsupport.cpp as well (and they probably originate from there).

@jkotas
Copy link
Member Author

jkotas commented Aug 4, 2023

Right, we had this bug in official builds since forever.

@jkotas jkotas merged commit 75225c3 into dotnet:main Aug 4, 2023
@jkotas jkotas deleted the arm64-hwcaps branch August 4, 2023 12:37
@EgorBo
Copy link
Member

EgorBo commented Aug 10, 2023

Looks like it improved a bunch of benchmarks on Linux-arm64 🙂

Look like RCPC is the culprit

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NativeAOT on Graviton2 As armv8.2-a Fails to Execute

3 participants