Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing outerloop tests and fix a build issue in MonoAOTCompiler #89922

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

akoeplinger
Copy link
Member

See #89921 for the test failures.

Additionally, the Android build was failing while compiling an AOT test due to this error:

/__w/1/s/artifacts/bin/Android.Device_Emulator.Aot.Test/Release/net8.0/android-x64/AppBundle/modules.c:51:6: error: no previous prototype for function 'register_aot_modules' [-Werror,-Wmissing-prototypes]
void register_aot_modules ()
     ^

This is because we turned on -Werror=missing-prototypes in #89197 but the MonoAOTCompiler didn't emit a function prototype in modules.c

Fixes #89566

@ghost
Copy link

ghost commented Aug 3, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

See #89921 for the test failures.

Additionally, the Android build was failing while compiling an AOT test due to this error:

/__w/1/s/artifacts/bin/Android.Device_Emulator.Aot.Test/Release/net8.0/android-x64/AppBundle/modules.c:51:6: error: no previous prototype for function 'register_aot_modules' [-Werror,-Wmissing-prototypes]
void register_aot_modules ()
     ^

This is because we turned on -Werror=missing-prototypes in #89197 but the MonoAOTCompiler didn't emit a function prototype in modules.c

Fixes #89566

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure-mono

Milestone: -

@akoeplinger

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@akoeplinger

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@akoeplinger

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

@akoeplinger

This comment was marked as outdated.

@azure-pipelines

This comment was marked as outdated.

See dotnet#89921 for the test failures.

Additionally, the Android build was failing while compiling an AOT test due to this error:

```
/__w/1/s/artifacts/bin/Android.Device_Emulator.Aot.Test/Release/net8.0/android-x64/AppBundle/modules.c:51:6: error: no previous prototype for function 'register_aot_modules' [-Werror,-Wmissing-prototypes]
void register_aot_modules ()
     ^
```

This is because we turned on `-Werror=missing-prototypes` in dotnet#89197 but the MonoAOTCompiler didn't emit a function prototype in modules.c

Fixes dotnet#89566
@akoeplinger
Copy link
Member Author

/azp run runtime-android

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger akoeplinger merged commit 1ceed18 into dotnet:main Aug 3, 2023
178 of 182 checks passed
@akoeplinger akoeplinger deleted the fix-outerloop branch August 3, 2023 13:26
@ghost ghost locked as resolved and limited conversation to collaborators Sep 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Build failure: no previous prototype for function 'register_aot_modules'
2 participants