Disable failing outerloop tests and fix a build issue in MonoAOTCompiler #89922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @directhex Issue DetailsSee #89921 for the test failures. Additionally, the Android build was failing while compiling an AOT test due to this error: This is because we turned on Fixes #89566
|
akoeplinger
force-pushed
the
fix-outerloop
branch
from
155058d
to
f4696c3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
akoeplinger
force-pushed
the
fix-outerloop
branch
from
f4696c3
to
1cd4959
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
See dotnet#89921 for the test failures. Additionally, the Android build was failing while compiling an AOT test due to this error: ``` /__w/1/s/artifacts/bin/Android.Device_Emulator.Aot.Test/Release/net8.0/android-x64/AppBundle/modules.c:51:6: error: no previous prototype for function 'register_aot_modules' [-Werror,-Wmissing-prototypes] void register_aot_modules () ^ ``` This is because we turned on `-Werror=missing-prototypes` in dotnet#89197 but the MonoAOTCompiler didn't emit a function prototype in modules.c Fixes dotnet#89566
akoeplinger
force-pushed
the
fix-outerloop
branch
from
1cd4959
to
4e7d639
Compare
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
steveisok
approved these changes
Aug 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #89921 for the test failures.
Additionally, the Android build was failing while compiling an AOT test due to this error:
This is because we turned on
-Werror=missing-prototypesin #89197 but the MonoAOTCompiler didn't emit a function prototype in modules.cFixes #89566