[release/7.0-staging] Fix COM object leak #89795
Conversation
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014 Issue DetailsBackport of #89745 to release/7.0-staging /cc @jkoritzinsky Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
approved. we will take for consideration in 7.0.x
|
Friendly reminder: if you want this servicing fix to be included in the September 2023 Release, you'll have to merge this PR before August 14th. |
|
@carlossanlop can you review the packaging changes? |
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
Packaging changes look good.
jkoritzinsky
added
Servicing-approved
|
Approved over email. |
|
Failure was a machine hang-up on AzDO, unrelated. Merging this in. |
Backport of #89745 to release/7.0-staging
/cc @jkoritzinsky
Customer Impact
Before this PR, only a single successful call to PrincipalContext.ValidateCredentials against the local SAM store will succeed even when the PrincipalContext is disposed correctly until the machine is restarted. This is a regression from 6.0
Testing
Local testing and validation against the other usages of the underlying API.
Risk
Low risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.