Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MVP part of const generics for CoreCLR #89636

Closed
wants to merge 86 commits into from
Closed

Implement MVP part of const generics for CoreCLR #89636

wants to merge 86 commits into from

Commits on Jul 20, 2023

  1. Parse const generic parameters

    @hez2010
    hez2010 committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4e55d7c View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Fixes to parsing and add basic binary layout support

    @hez2010
    hez2010 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    72fcce6 View commit details
    Browse the repository at this point in the history

  2. More fixes to naming

    @hez2010
    hez2010 committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    05034f0 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Complete assembly emitter

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    b7cf656 View commit details
    Browse the repository at this point in the history

  2. Emit const generics for method

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    19d1702 View commit details
    Browse the repository at this point in the history

  3. Add ildasm support for const generics declaration

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    7713175 View commit details
    Browse the repository at this point in the history

  4. Introduce meta model v2.1

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    eb021d9 View commit details
    Browse the repository at this point in the history

  5. Add parsing and emitting support for instantiation and calling

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    79f5bc3 View commit details
    Browse the repository at this point in the history

  6. Move opcode def upper

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    c29b87d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dotnet:main' into feature/const-generics

    @hez2010
    hez2010 authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    3d2835c View commit details
    Browse the repository at this point in the history

  8. Implement ldtarg and ldtarg.s in parser, emitter and disasmer

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    a9f166a View commit details
    Browse the repository at this point in the history

  9. Support using type parameter index directly in parser

    @hez2010
    hez2010 committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    b18f20e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. Remove ldtc.* and rename ldtarg to ldctarg

    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    4b7d14f View commit details
    Browse the repository at this point in the history

  2. Remove unused ELEMENT_TYPE_CONSTTYPE

    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    084651c View commit details
    Browse the repository at this point in the history

  3. Fix a bug where CorSigUncompressConstTypeArgData shifts dataPtr by mi… 

    …stake
    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    8ebd325 View commit details
    Browse the repository at this point in the history

  4. Fix ldctarg def

    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    15d0a2c View commit details
    Browse the repository at this point in the history

  5. Fix the missing data len addition to typePtr

    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    a34f4bf View commit details
    Browse the repository at this point in the history

  6. Bump metamodel version to v3.0 and add fallback schema for v2.0

    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    c51378d View commit details
    Browse the repository at this point in the history

  7. Load assembly in VM

    @hez2010
    hez2010 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    e247c0e View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Back-compat fixes and add some helpers for const generics

    @hez2010
    hez2010 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    14de598 View commit details
    Browse the repository at this point in the history

  2. WIP: ConstValueEEType and MethodTable changes

    @hez2010
    hez2010 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c5dd614 View commit details
    Browse the repository at this point in the history

  3. Remove redundant szPrefix

    @hez2010
    hez2010 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    3d58e01 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Add the missing const in ildasm

    @hez2010
    hez2010 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    f3cb8ab View commit details
    Browse the repository at this point in the history

  2. Add isConst to CorTypeInfo

    @hez2010
    hez2010 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    97a7b06 View commit details
    Browse the repository at this point in the history

  3. Minor fixes

    @hez2010
    hez2010 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6eee670 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. WIP: MethodTableBuilder and ClassLoader support for ConstValueType

    @hez2010
    hez2010 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5835cf8 View commit details
    Browse the repository at this point in the history

  2. WIP: TypeLoader for const value

    @hez2010
    hez2010 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6d3c1f3 View commit details
    Browse the repository at this point in the history

  3. Complete class loader implementation

    @hez2010
    hez2010 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    87d8006 View commit details
    Browse the repository at this point in the history

  4. Use AppendTypeDef for const generic variable typestring

    @hez2010
    hez2010 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5dbda0a View commit details
    Browse the repository at this point in the history

  5. Handle CVAR and MCVAR in GetTypeHandleThrowing

    @hez2010
    hez2010 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    bb9a907 View commit details
    Browse the repository at this point in the history

  6. Updates to JIT-EE interfaces

    @hez2010
    hez2010 committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5c5ad11 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Implement type lookup for ELEMENT_TYPE_CTARG

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    ccdd3a8 View commit details
    Browse the repository at this point in the history

  2. Add support for hashing const value type

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d663329 View commit details
    Browse the repository at this point in the history

  3. Change the way of encoding ldctarg, and remove ldctarg.s

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    4225bf1 View commit details
    Browse the repository at this point in the history

  4. Use ldtoken instead of ldctarg

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    71a0664 View commit details
    Browse the repository at this point in the history

  5. Complete!

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    faba1ec View commit details
    Browse the repository at this point in the history

  6. Fix data gets truncated due to cast.

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6ee5cf5 View commit details
    Browse the repository at this point in the history

  7. Add a NYI note around type loader.

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    6a45bb2 View commit details
    Browse the repository at this point in the history

  8. Fixes for type resolving on (M)CVAR

    @hez2010
    hez2010 committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    306b09a View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Implement superpmi

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    167bff9 View commit details
    Browse the repository at this point in the history

  2. Implement const value lookup

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    179cb05 View commit details
    Browse the repository at this point in the history

  3. Implement support for const generic virtual methods

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    b891897 View commit details
    Browse the repository at this point in the history

  4. Remove ELEMENT_TYPE_{M}CVAR

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9137b04 View commit details
    Browse the repository at this point in the history

  5. Clean up

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6639399 View commit details
    Browse the repository at this point in the history

  6. Add missing superpmi implementation

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    9db89cf View commit details
    Browse the repository at this point in the history

  7. Fix the incorrect type mapping on uint64_t

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    f7c68cf View commit details
    Browse the repository at this point in the history

  8. Add NYI for JIT-EE interfaces in managed type system.

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    8709dd8 View commit details
    Browse the repository at this point in the history

  9. Initialize pResolvedToken correctly

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    1bebc8d View commit details
    Browse the repository at this point in the history

  10. Use uint64_t for all const values

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    6f9db7c View commit details
    Browse the repository at this point in the history

  11. Clean up unmeaningful changes

    @hez2010
    hez2010 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    d1a4652 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Merge branch 'main' into feature/const-generics

    @hez2010
    hez2010 authored Jul 29, 2023
    Configuration menu
    Copy the full SHA
    4b55eb0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Parsing bytearray and string

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    21d262f View commit details
    Browse the repository at this point in the history

  2. Char size fixes

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    d5d18d6 View commit details
    Browse the repository at this point in the history

  3. Use CorInfoType in jitinterface

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    49e95ab View commit details
    Browse the repository at this point in the history

  4. Initialize CORINFO_RESOLVED_TOKEN

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    97a60aa View commit details
    Browse the repository at this point in the history

  5. Fix an assert

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    e554aa5 View commit details
    Browse the repository at this point in the history

  6. Bring back CORINFO_TYPE_CTARG

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    30b0681 View commit details
    Browse the repository at this point in the history

  7. Fix hash function for const value

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    e75a400 View commit details
    Browse the repository at this point in the history

  8. Handle default case in appendStrBlob

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    2a8ae6d View commit details
    Browse the repository at this point in the history

  9. Use uint64_t instead of DWORDLONG

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    6d9b91e View commit details
    Browse the repository at this point in the history

  10. Fix formatting

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    8a6fbf5 View commit details
    Browse the repository at this point in the history

  11. Switch back to DWORDLONG and use PRIX64

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    9500e1b View commit details
    Browse the repository at this point in the history

  12. DWORDLONG leftovers

    @hez2010
    hez2010 committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    fe1f48b View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Minor fixes

    @hez2010
    hez2010 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b5ec226 View commit details
    Browse the repository at this point in the history

  2. Use bison for ilasm parser generator

    @hez2010
    hez2010 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    424e9a2 View commit details
    Browse the repository at this point in the history

  3. Fix asmparse build failure

    @hez2010
    hez2010 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3bf3d70 View commit details
    Browse the repository at this point in the history

  4. Fix the missing fallback path to GenericParamRec

    @hez2010
    hez2010 committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    5a018b2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dotnet:main' into feature/const-generics

    @hez2010
    hez2010 authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    80ff093 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Add support for type validation

    @hez2010
    hez2010 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    af861b4 View commit details
    Browse the repository at this point in the history

  2. Implement typestring for const type parameter

    @hez2010
    hez2010 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9b76911 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dotnet:main' into feature/const-generics

    @hez2010
    hez2010 authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    9a90c35 View commit details
    Browse the repository at this point in the history

  4. Fix build failure

    @hez2010
    hez2010 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    20db638 View commit details
    Browse the repository at this point in the history

  5. Fix format

    @hez2010
    hez2010 committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    1d6c3f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Fix generics on const type parameter parsing

    @hez2010
    hez2010 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    2e10415 View commit details
    Browse the repository at this point in the history

  2. Use byacc for ilasm parser generator

    @hez2010
    hez2010 committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    7dc3c45 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Parse constraints for const type parameter

    @hez2010
    hez2010 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    a2d4d3f View commit details
    Browse the repository at this point in the history

  2. Correctly format method name

    @hez2010
    hez2010 committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    edab29d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Reuse "literal" keyword in IL and get rid of "const"

    @hez2010
    hez2010 committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    902e196 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'main' into feature/const-generics

    @hez2010
    hez2010 authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b8bee87 View commit details
    Browse the repository at this point in the history

  2. Generate new JIT-EE interface

    @hez2010
    hez2010 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    c8a2702 View commit details
    Browse the repository at this point in the history

  3. Fix some comments

    @hez2010
    hez2010 committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    4bd7a65 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Use TypeHandle for ConstValueType

    @hez2010
    hez2010 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    9a7013f View commit details
    Browse the repository at this point in the history

  2. Use TypeHandle in class loader

    @hez2010
    hez2010 committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a70dfdc View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Support const generic type to be used in a field

    @hez2010
    hez2010 committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    7044cc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Merge branch 'main' into feature/const-generics

    @hez2010
    hez2010 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    c8a2ccf View commit details
    Browse the repository at this point in the history

  2. Emit type of type parameter in generic constraint table

    @hez2010
    hez2010 committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    5d3da96 View commit details
    Browse the repository at this point in the history