Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Look for Native Signal SIMD Context #89467

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

fanyang-mono
Copy link
Member

@fanyang-mono fanyang-mono commented Jul 25, 2023

This PR add the logic to find the native signal SIMD context, instead of assuming the first one in the array is the one. If not found, it is okay to proceed from the first context as well.

Somehow, when running android arm64 apps on x64 emulators, the SIMD context doesn't exist.

Testing: Followed the reproduction steps provided by the customer using VS 2022 (#62201 (comment))

Fixes #62201

@ghost ghost assigned fanyang-mono Jul 25, 2023
@fanyang-mono fanyang-mono marked this pull request as ready for review July 25, 2023 19:59
@fanyang-mono fanyang-mono changed the title [Mono] Find Native Signal SIMD Context [Mono] Look for Native Signal SIMD Context Jul 25, 2023
@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89467 in repo dotnet/runtime

@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

src/mono/mono/utils/mono-context.c Outdated Show resolved Hide resolved
@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 26, 2023
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jul 26, 2023
@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 89467 in repo dotnet/runtime

@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fanyang-mono
Copy link
Member Author

Test failures on CI are unrelated.

@fanyang-mono
Copy link
Member Author

/backport to release/7.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/7.0-staging: https://github.com/dotnet/runtime/actions/runs/5681844886

@fanyang-mono fanyang-mono merged commit 7350a76 into dotnet:main Jul 27, 2023
125 of 152 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[android] arm64 running on x64 emulator unexpected FPSIMD_MAGIC assert
3 participants