-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[iOS] HybridGlobalization Implement missing cases for GlobalizationNative_GetLocaleInfoString #89296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[iOS] HybridGlobalization Implement missing cases for GlobalizationNative_GetLocaleInfoString #89296
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5ac9461
Cahnges to return missing locale properties
mkhamoyan 548e34a
Refactor functions
mkhamoyan a8976cc
Order test files and add EnglishName tests
mkhamoyan e6a49f1
Merge branch 'main' into hybrid_locale_properties
mkhamoyan f17d8c0
update order of LocaleStringData cases
mkhamoyan f032d86
clean up the code
mkhamoyan d800ae6
add whitespace
mkhamoyan 8c53bf5
use strncasecmp and minor refactorings
mkhamoyan f6d9afa
Remove static tables and call icu function
mkhamoyan 4268488
Merge branch 'main' into hybrid_locale_properties
mkhamoyan 8209fa6
Merge branch 'main' into hybrid_locale_properties
mkhamoyan 4cf91d2
Merge branch 'main' into hybrid_locale_properties
mkhamoyan 5afb93a
not run on OSX platform
mkhamoyan 98c2944
Rename OSX files to iOS
mkhamoyan 1234322
update entrypoints
mkhamoyan a1eadfa
Merge branch 'main' into hybrid_locale_properties
mkhamoyan 6aaa76e
inlcude icu lib files for nativeaot tests
mkhamoyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/libraries/System.Globalization/tests/CultureInfo/CultureInfoThreeLetterISOInfo.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Xunit; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace System.Globalization.Tests | ||
| { | ||
| public class CultureInfoThreeLetterISOInfo | ||
| { | ||
| public static IEnumerable<object[]> RegionInfo_TestData() | ||
| { | ||
| yield return new object[] { 0x409, 244, "en-US", "USA", "eng" }; | ||
| yield return new object[] { 0x411, 122, "ja-JP", "JPN", "jpn" }; | ||
| yield return new object[] { 0x804, 45, "zh-CN", "CHN", "zho" }; | ||
| yield return new object[] { 0x401, 205, "ar-SA", "SAU", "ara" }; | ||
| yield return new object[] { 0x412, 134, "ko-KR", "KOR", "kor" }; | ||
| yield return new object[] { 0x40d, 117, "he-IL", "ISR", "heb" }; | ||
| } | ||
|
|
||
| [Theory] | ||
| [MemberData(nameof(RegionInfo_TestData))] | ||
| public void MiscTest(int lcid, int geoId,string name, string threeLetterISORegionName, string threeLetterISOLanguageName) | ||
| { | ||
| RegionInfo ri = new RegionInfo(lcid); // create it with lcid | ||
| Assert.Equal(geoId, ri.GeoId); | ||
| Assert.Equal(threeLetterISORegionName, ri.ThreeLetterISORegionName); | ||
| Assert.Equal(threeLetterISOLanguageName, new CultureInfo(name).ThreeLetterISOLanguageName); | ||
| } | ||
| } | ||
| } | ||
48 changes: 0 additions & 48 deletions
48
src/libraries/System.Globalization/tests/Hybrid/HybridMode.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.