Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new streaming APIs for the System.Net.Http.Json extensions #89258

Merged
merged 14 commits into from
Jul 24, 2023
Merged

Implement new streaming APIs for the System.Net.Http.Json extensions #89258

merged 14 commits into from
Jul 24, 2023

Commits on Jul 19, 2023

  1. Contributes to dotnet#87577

    @IEvangelist
    IEvangelist committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    ed44a47 View commit details
    Browse the repository at this point in the history

  2. More updates

    @IEvangelist
    IEvangelist committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9901e29 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Added unit tests, generated ref, and minor clean up

    @IEvangelist
    IEvangelist committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    352141c View commit details
    Browse the repository at this point in the history

  2. Added missing triple slash comments

    @IEvangelist
    IEvangelist committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    73c44b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Update src/libraries/System.Net.Http.Json/tests/FunctionalTests/HttpC… 

    …lientJsonExtensionsTests.cs

Co-authored-by: Eirik Tsarpalis <[email protected]>
    @IEvangelist @eiriktsarpalis
    IEvangelist and eiriktsarpalis authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    04a2537 View commit details
    Browse the repository at this point in the history

  2. Correct the preprocessor directives, and delegate to JsonTypeInfo ove… 

    …rload - per peer feedback.
    @IEvangelist
    IEvangelist committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ad465c8 View commit details
    Browse the repository at this point in the history

  3. Refactor for deferred execution, remove helper methods since they're … 

    …no longer needed
    @IEvangelist
    IEvangelist committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    4c4ff60 View commit details
    Browse the repository at this point in the history

  4. Add test to ensure deferred execution semantics, updates from Miha.

    @IEvangelist
    IEvangelist committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7c76121 View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Miha Zupan <[email protected]>
    @IEvangelist @MihaZupan
    IEvangelist and MihaZupan authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    f790d55 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Update src/libraries/System.Net.Http.Json/src/System/Net/Http/Json/Ht… 

    …tpClientJsonExtensions.Get.AsyncEnumerable.cs

Co-authored-by: Eirik Tsarpalis <[email protected]>
    @IEvangelist @eiriktsarpalis
    IEvangelist and eiriktsarpalis authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b73f3ce View commit details
    Browse the repository at this point in the history

  2. Update test per Miha's feedback

    @IEvangelist
    IEvangelist committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    deb2409 View commit details
    Browse the repository at this point in the history

  3. A few more updates from peer review, Eirik's nits.

    @IEvangelist
    IEvangelist committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    ad03a32 View commit details
    Browse the repository at this point in the history

  4. No need for the length limit read stream.

    @IEvangelist
    IEvangelist committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c99e708 View commit details
    Browse the repository at this point in the history

  5. Add limit per invocation, not element. Share length limit read stream… 

    … logic.
    @IEvangelist
    IEvangelist committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a1528ff View commit details
    Browse the repository at this point in the history