JIT: Cache memory dependencies for VN map selects #89241
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoisting relies on being able to look at which memory definitions a candidate is dependent upon. VN tracks these during the map select logic; however, it fails to do so when the map selection hits the cache. This changes the logic to make sure the memory dependencies are cached.
Fix #75442
TP impact of the "obvious" approach was not as bad as I expected; below 0.1%.
Diff of memory stats over win-x64 aspnet. This costs about 1% more ValueNumber memory, which amounts to about 0.09% more overall memory usage.
Note: this is best reviewed with whitespace diffs turned off as I have unnested some code in
VNForMapSelectWork
.