-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable CLS Compliance on Diagnostics Libraries #89214
Enable CLS Compliance on Diagnostics Libraries #89214
Conversation
I assume the affect of this change is that a CLSCompliant attribute at assembly scope changes from false to true (or maybe goes away if that is the default), and now other libraries that reference this one don't get compiler warnings? That sounds pretty good to me. Are you aware of any scenario where the experience gets worse? I can't think of anything offhand. |
By default, if the
I am not either, adding @ericstj @ViktorHofer if they can think in any broken scenario after this change. The opposite direction is the breaking one, I guess. |
I'm not aware of anything breaking by adding CLSCompliant(true). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This change will allow the consumers of these libraries not to be forced to set CLS Compliance off.